Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 for web impl get agent refactor #1466

Open
wants to merge 94 commits into
base: fdc3-for-web-impl
Choose a base branch
from
Open

Fdc3 for web impl get agent refactor #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
664ad77
Linting setup
kriswest Nov 19, 2024
3dd0fd2
WIP GetAgent refactor
kriswest Nov 19, 2024
2614791
Better encapsulate handshake and identity messaging and reuse in fail…
kriswest Nov 19, 2024
9fa5f1e
Adding timeouts to loaders and eliminating TimeoutLoader
kriswest Nov 20, 2024
ae5ef1e
Limit connection strategies based on persisted data
kriswest Nov 20, 2024
f8a2761
use a previously persisted agentUrl in PostMessageLoader if available
kriswest Nov 20, 2024
c8e9dff
typing on waitFor and exchange + some cleanup in AbstractWebMessaging…
kriswest Nov 20, 2024
4aaa941
Further cleanup of Messaging and Listeners, additional typing
kriswest Nov 22, 2024
f4713c4
Cleanup and simplify AbstractListener
kriswest Nov 25, 2024
810cf33
Merge branch 'fdc3-for-web-fix-private-channel-events' into fdc3-for-…
kriswest Nov 25, 2024
fb7c0b7
Refactor PrivateChannel event listener support
kriswest Nov 25, 2024
23f8ad1
Messaging refactor
kriswest Nov 26, 2024
070a413
Corrections to PrivateChannelAddEventListenerRequest
kriswest Nov 26, 2024
1254cc9
Merge branch 'fdc3-for-web-impl-update-type-predicates' into fdc3-for…
kriswest Nov 26, 2024
06c6c9c
More typing work on Listener and PrivateChannel events
kriswest Nov 26, 2024
59ad838
Better logging in getAgent
kriswest Nov 28, 2024
a54b2f7
Send WCP6Goodbye on disconnects - inside MessagePortMessaging
kriswest Nov 28, 2024
832349f
minor tweaks to heartbeats
kriswest Nov 29, 2024
f066ffb
typing in UI component handling
kriswest Nov 29, 2024
9b236ea
Add fdc3 version to standard package
kriswest Nov 29, 2024
721ba3e
Additional logging in getAgent
kriswest Nov 29, 2024
1ea6f9e
minor logging tweaks
kriswest Nov 29, 2024
5c37064
minor schema correction in fdc3UserInterfaceResolveAction
kriswest Nov 29, 2024
b95cc60
iframe adaptor responds to hello message
kriswest Nov 29, 2024
fd2870c
Refactoring fdc3-get-agent tests
kriswest Nov 29, 2024
fee7d44
Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-getAgent-refa…
kriswest Nov 29, 2024
5b1b0b1
getAgent tests passing + reducing log messaging during tests
kriswest Dec 2, 2024
314b313
some minor logging additions for debug use
kriswest Dec 2, 2024
7914ac2
improving typescript use in fdc3-agent-proxy
kriswest Dec 3, 2024
f99e46b
adjusting privateChannel tests to match correct to private channel ev…
kriswest Dec 3, 2024
7341ebe
code formating and minor improvements in toolbox/fdc3-for-web impleme…
kriswest Dec 3, 2024
26dd356
Improved typing and fixes to agent-proxy tests (6 still need fixing)
kriswest Dec 4, 2024
25314d2
agent-proxy tests passing, fix PrivateChannel event and getInfo handling
kriswest Dec 4, 2024
fc3438d
dealing private channel event listener changes in fdc3-web-impl
kriswest Dec 4, 2024
e567678
more typing and formatting in fdc3-get-agent
kriswest Dec 6, 2024
89a8ae2
more test cleanup and adding a test for failed validation
kriswest Dec 6, 2024
de83692
fdc3-get-agent tests coverage
kriswest Dec 9, 2024
8a981c8
Further refactor of fdc3-get-agent tests and improving coverage
kriswest Dec 10, 2024
c3aaf80
Merging eslint and prettier changes
kriswest Dec 10, 2024
74daa90
Attempting to deal with SemGrep issues with log messages
kriswest Dec 10, 2024
b650a63
Fixing remaining BrowserTypes imports
kriswest Dec 10, 2024
1ddc9d9
Further work on resolving logging semgrep complaints
kriswest Dec 10, 2024
0565704
Further attempt to resolve SemGrep logging issues
kriswest Dec 10, 2024
d1ced23
reworking Logger again to appease semgrep
kriswest Dec 10, 2024
e39185b
Output error stack traces in Logger
kriswest Dec 10, 2024
b83b099
failoverhandler test coverage
kriswest Dec 11, 2024
0ea5b95
lint free fdc3-get-agent
kriswest Dec 11, 2024
731b2ec
lint in fdc3-web-impl
kriswest Dec 11, 2024
7304989
lint in fdc3-web-impl and reference-ui
kriswest Dec 11, 2024
4000f3d
lint in demo
kriswest Dec 11, 2024
7b330ac
Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-getAgent-refa…
kriswest Dec 11, 2024
29935c1
Addressing review feedback
kriswest Dec 12, 2024
db6b481
Removing redundant cleanup steps
kriswest Dec 12, 2024
fec54c8
Clear timers when no longer needed in AbstractMessaging
kriswest Dec 12, 2024
69d0bbc
Update function in docs that searches for parent frames
kriswest Dec 16, 2024
2f7d131
Renaming BasicDesktopAgent to DesktopAgentProxy (as that better repre…
kriswest Dec 16, 2024
b69afaa
minor formatting spelling and typing fixes in fdc3-agent-proxy
kriswest Dec 16, 2024
4730887
Address review comments
kriswest Dec 16, 2024
d5c4e20
Resolving comments from Rob's review
kriswest Dec 17, 2024
fe42de4
Remove defunct code in DefaultIntentListener
kriswest Dec 17, 2024
e35a162
Fix error introduced into UI iframe test infrastructure
kriswest Dec 17, 2024
4da3542
Resolving review comments from Julianna's final batch
kriswest Dec 17, 2024
180f24c
Refactored FailoverHandler into separate smaller functions, tidied up…
robmoffat Dec 18, 2024
d81df1b
Merge branch 'fdc3-for-web-impl-getAgent-refactor' into fdc3-for-web-…
robmoffat Dec 18, 2024
0c86b2d
Merge pull request #1476 from finos/fdc3-for-web-impl-getAgent-refact…
kriswest Dec 18, 2024
7d5e67c
Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-getAgent-refa…
kriswest Dec 18, 2024
f2b1b1d
Note on wtfnode use
kriswest Dec 18, 2024
10aba7f
Update packages/fdc3-agent-proxy/src/intents/DefaultIntentSupport.ts
kriswest Dec 19, 2024
1ec1237
Resolving comments from Rob's review
kriswest Dec 19, 2024
1f42fa6
Addressing Rob's coverage comments
kriswest Dec 19, 2024
279bad3
SSimplify DefaultIntentSupport.raiseIntent* coverage
kriswest Dec 19, 2024
442956d
Test channel selector callback
kriswest Dec 20, 2024
d65d1db
Make sure MessagePort is started for identity validation
kriswest Dec 23, 2024
9b06c26
fix dependency mismatches
kriswest Dec 23, 2024
0468da6
Correcting issues with reconnection in fdc3-for-web-impl and demo
kriswest Jan 2, 2025
9d1317c
IntentHandler test coverage
kriswest Jan 2, 2025
3b795ea
catch cross-domain window.name accesses
kriswest Jan 2, 2025
455b205
some lint and logging
kriswest Jan 2, 2025
9c54ec9
Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-getAgent-refa…
kriswest Jan 7, 2025
5312abb
cleanup package-lock
kriswest Jan 7, 2025
31c0781
Better validation of addContextListener args and testing of error on …
kriswest Jan 8, 2025
50a4731
Revert to importing all of BrowserTypes as CommonJS compile doesn't l…
kriswest Jan 8, 2025
d248137
Addressing review comments including using appState.terminated for pa…
kriswest Jan 9, 2025
ec14275
Refining fdc3-for-web-impl's findIntent fns, tests and cleanup on dis…
kriswest Jan 9, 2025
1cb72b9
rolling package verison numbers
kriswest Jan 9, 2025
b6b04e1
Fix getAgent tests after previous change to fdc3-for-web-impl
kriswest Jan 9, 2025
525b800
syncpack
kriswest Jan 9, 2025
a305b93
syncing more package.json version nums
kriswest Jan 10, 2025
27ccc55
Import picocolors to fix commonjs build
kriswest Jan 10, 2025
b03197a
timing improvements to injected UIs
kriswest Jan 10, 2025
5117a58
Ignore untested parts of picocolors for coverage
kriswest Jan 10, 2025
53bbaba
correcting updateChannel in test implementations of channelSelectors
kriswest Jan 10, 2025
5e2fd55
Picocolors testing exemption
kriswest Jan 10, 2025
91449c9
protect messaging in DefaultChannel
kriswest Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .semgrepignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ website/**

# Just used for build so ignoring
s2tQuicktypeUtil.js
t2sQuicktypeUtil.js

# API schema set for localhost gets picked up by semgrep rule
schemas/bridgingAsyncAPI/bridgingAsyncAPI.json
schemas/bridgingAsyncAPI/bridgingAsyncAPI.json

# demo apps get picked up for not having integrity headers
toolbox/fdc3-for-web/demo/src/client/apps/**
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,6 @@ THIS STANDARD IS BEING OFFERED WITHOUT ANY WARRANTY WHATSOEVER, AND IN PARTICULA

## FDC3 Archive

An archive of FDC3 documentation and meeting notes is available at <https://finosfoundation.atlassian.net/wiki/spaces/FDC3/overview>. The mailing list archive for [[email protected]](mailto:[email protected]) is available at <https://groups.google.com/a/finos.org/g/fdc>
An archive of FDC3 documentation and meeting notes from the early days of FDC3 is available at <https://finosfoundation.atlassian.net/wiki/spaces/FDC3/overview>. Later meeting minutes cam be found in closed Github issues.

The mailing list archive for [[email protected]](mailto:[email protected]) is available at <https://groups.google.com/a/finos.org/g/fdc3>
Loading
Loading