Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Context data and intents consolidated update branch 2.1 #936

Closed

Conversation

mistryvinay
Copy link
Contributor

@mistryvinay mistryvinay commented Mar 22, 2023

Proposed FDC3 2.1 Release
Consolidated PR for Context Data & Intents (CD&I) updates (each of which is raised as a separate PR into this branch for review by CD&I discussion group members, maintainers and editors).

milindchidrawar and others added 30 commits June 7, 2022 15:13
…eraction

Updated PR with latest FDC3/master
…on' into context-data-and-intents-consolidated-update-branch-2.1
…' of https://github.com/finos/FDC3 into context-data-and-intents-consolidated-update-branch-2.1
@mistryvinay mistryvinay added this to the 2.1 milestone Mar 22, 2023
@mistryvinay mistryvinay added context-data FDC3 Context Data Working Group intents Context Data & Intents Contexts & Intents Discussion Group labels Mar 22, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@kriswest kriswest force-pushed the context-data-and-intents-consolidated-update-branch-2.1 branch from 06ff641 to ab3660d Compare March 24, 2023 18:39
…dates

Symphony PRs in FDC3 2.1 candidates
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 27, 2023

CLA Not Signed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kriswest are we omitting the addition of the Order object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I thought you'd managed to back this one out @mistryvinay

https://github.com/finos/FDC3/commits/ad95a1b20d752ccfb0ab618bb641d28b8642bbfe/docs/context/ref/Order.md

It is possible to unmerge (rather than revert) something, but difficult. I'll see if I can find the instructions I last used for doing so and will report back. Don't merge in anything else (including the PR I just tagged you in) until we've had a go

Copy link
Contributor Author

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kriswest seems we have included the original Order type in this commit.

@mistryvinay
Copy link
Contributor Author

Closing this PR as its being replaced by #994

@mistryvinay mistryvinay deleted the context-data-and-intents-consolidated-update-branch-2.1 branch May 18, 2023 14:02
@kriswest kriswest removed this from the 2.1 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment