Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perspective crate, link perspective-server as static lib #2734

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 2, 2024

#2707 split the perspective-server crate into a stand-alone .so for the C++ part of the code base that needed be be built, bundled and imported separately from the Rust client. This fixed perspective-python when compiled via Emscripten, but broke the perspectve Rust crate and caused general build havoc.

This PR partially reverts #2707:

  • Deletes perspective-python's duplication of the cmake build logic, src tree cloning, etc.
  • Modifies perspective-server to build the C++ deps as a static lib.
  • Adds perspective-rs to the build and CI system. This library is now built, tested and packaged on CI.
  • Re-implemented perspective-server internal C++ library binding, from cxx to a hand-rolled FFI.

@texodus texodus added the bug Concrete, reproducible bugs label Sep 2, 2024
@texodus texodus changed the title Fix perspective crate, static link perspective-server Fix perspective crate, statically link perspective-server Sep 2, 2024
@texodus texodus changed the title Fix perspective crate, statically link perspective-server Fix perspective crate, link perspective-server as static lib Sep 2, 2024
@texodus texodus marked this pull request as ready for review September 2, 2024 19:54
@texodus texodus merged commit d477a58 into master Sep 2, 2024
10 checks passed
@texodus texodus deleted the remove-cxx branch September 2, 2024 19:54
@texodus texodus restored the remove-cxx branch September 2, 2024 19:54
@texodus texodus deleted the remove-cxx branch September 2, 2024 19:54
@texodus texodus mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant