Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUU-333: Include username in local storage layout key #1105

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

pling-scottlogic
Copy link
Contributor

Description

When using the local implementation of layout management, the relevant information is saved to local storage under the keys layouts/layouts, layouts/metadata and api/vui. This can cause problems once a second user is introduced, so we change the keys here to include a username. We also add the username to cookies for the NewTheme showcase example, matching the behaviour of the sample app.

Change List

  • Add username to local storage keys (application layout, layout and metadata)
  • Convert private functions in LocalLayoutPersistenceManager to arrow functions
  • Get actual username from cookies
  • Add username to cookies for showcase example

Testing

Saving and loading layouts tested using local and remote implementations, from both showcase and sample app.

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit e7e868f
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/6597cd67d4ecc6000834c761

@heswell heswell merged commit c34972a into finos:main Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants