Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor build to better handle fonts and css #1122

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,463 changes: 3 additions & 2,460 deletions vuu-ui/packages/vuu-data-remote/src/inlined-worker.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions vuu-ui/packages/vuu-icons/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "./src/VuuLogo";
2 changes: 1 addition & 1 deletion vuu-ui/packages/vuu-icons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@finos/vuu-icons",
"version": "0.0.26",
"description": "css embedded svg icons plus icon components for Vuu",
"main": "src/index.ts",
"main": "index.ts",
"license": "Apache-2.0",
"style": "index.css",
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion vuu-ui/packages/vuu-icons/src/index.ts

This file was deleted.

3 changes: 0 additions & 3 deletions vuu-ui/packages/vuu-table-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"build": "node ../../scripts/run-build.mjs"
},
"types": "index.d.ts",
"files": [
"index.d.ts"
],
"devDependencies": {
"@finos/vuu-protocol-types": "0.0.26"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
font-weight: 300;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

Expand All @@ -16,7 +16,7 @@
font-weight: 400;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

Expand All @@ -27,7 +27,7 @@
font-weight: 500;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

Expand All @@ -38,7 +38,7 @@
font-weight: 600;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

Expand All @@ -49,7 +49,7 @@
font-weight: 700;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

Expand All @@ -60,12 +60,12 @@
font-weight: 800;
font-stretch: 100%;
font-display: swap;
src: url(./NunitoSansv15Latin.woff2) format('woff2');
src: url(./fonts/NunitoSansv15Latin.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

/* This font contains the variation of the 'a' character, which can be applied with `font-feature-settings` as per Figma */
@font-face {
font-family: 'Nunito Sans A-Variant';
src: url('./NunitoSans-Regular.woff') format('opentype');
src: url('./fonts/NunitoSans-Regular.woff') format('opentype');
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
font-style: normal;
font-weight: 500;
font-display: swap;
src: url(./SomeTypeMonov1-500.woff2) format('woff2');
src: url(./fonts/SomeTypeMonov1-500.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}
Binary file removed vuu-ui/packages/vuu-theme/fonts/NunitoSansv15.woff2
Binary file not shown.
4 changes: 2 additions & 2 deletions vuu-ui/packages/vuu-theme/index.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import url(fonts/NunitoSans.css);
@import url(fonts/SomeTypeMono.css);
@import url(NunitoSans.css);
@import url(SomeTypeMono.css);
@import url(css/global.css);
@import url(css/theme.css);
@import url(css/components/components.css);
3 changes: 3 additions & 0 deletions vuu-ui/packages/vuu-theme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "0.0.26",
"license": "Apache-2.0",
"style": "index.css",
"files": [
"fonts"
],
"scripts": {
"build": "node ../../scripts/run-build.mjs"
}
Expand Down
58 changes: 48 additions & 10 deletions vuu-ui/scripts/build.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const defaultConfig = {
};

const workerTS = "src/worker.ts";
const indexTS = "src/index.ts";
const indexTS = "index.ts";
const indexSrcTS = "src/index.ts";
const indexDTS = "index.d.ts";
const indexJS = "src/index.js";
const indexCSS = "index.css";
Expand Down Expand Up @@ -75,16 +76,36 @@ export default async function main(customConfig) {
const jsonOutput = getCommandLineArg("--json");
const outdir = `${DIST_PATH}/${packageName}${debug ? "-debug" : ""}`;

const FONT_FILES = ["*.woff", "*.woff2"];

const hasWorker = fs.existsSync(workerTS);
const hasReadme = fs.existsSync(README);
const isTypeScriptSrc = fs.existsSync(indexSrcTS);
const isTypeScript = fs.existsSync(indexTS);
const isTypeLib = fs.existsSync(indexDTS);
const isJavaScript = fs.existsSync(indexJS);
const hasRootCss = fs.existsSync(indexCSS);

const getEntryPoints = () => {
const entryPoint = isTypeScriptSrc
? indexSrcTS
: isTypeScript
? indexTS
: isJavaScript
? indexJS
: indexCSS;
const entryPoints = [entryPoint];
// We may have a top-level css as well as typescript (icons)
if (hasRootCss && !entryPoint.endsWith(".css")) {
entryPoints.push(indexCSS);
}
return entryPoints;
};

const buildConfig = {
entryPoints: [isTypeScript ? indexTS : isJavaScript ? indexJS : indexCSS],
entryPoints: getEntryPoints(),
env: development ? "development" : "production",
external: external.concat(externalVuu),
external: external.concat(externalVuu).concat(FONT_FILES),
outdir: `${outdir}/esm`,
name: scopedPackageName,
target,
Expand All @@ -95,23 +116,31 @@ export default async function main(customConfig) {
fs.mkdirSync(outdir, { recursive: true });
}

const GeneratedFiles = /^(worker|index)\.(js|css)(\.map)|(esm)?$/;
const GeneratedFiles = /^((worker|index)\.(js|css))|((\.map)|(esm))$/;

async function writePackageJSON(options) {
return new Promise((resolve, reject) => {
const {
files = getDefaultFilesToPublish(options),
files: filesFromPackageJson,
// eslint-disable-next-line no-unused-vars
main,
// eslint-disable-next-line no-unused-vars
scripts,
style: styleFromPackageJson,
types,
...packageRest
} = packageJson;
if (files) {

let files = getDefaultFilesToPublish(options);
let defaultStyle = undefined;

if (filesFromPackageJson) {
const filesToPublish = isTypeLib
? [indexDTS]
: files.filter((fileName) => !GeneratedFiles.test(fileName));
: filesFromPackageJson.filter(
(fileName) => !GeneratedFiles.test(fileName)
);
files = filesToPublish.concat(files);
if (filesToPublish.length) {
filesToPublish.forEach((fileName) => {
const filePath = fileName.replace(/^\//, "./");
Expand All @@ -128,11 +157,21 @@ export default async function main(customConfig) {
});
}
}
const newPackage = { ...packageRest, files };

const cssFile = files.find((f) => f.endsWith(".css"));
if (cssFile) {
defaultStyle = cssFile;
}

const newPackage = {
...packageRest,
files,
style: styleFromPackageJson ?? defaultStyle,
};

if (isTypeLib) {
newPackage.types = types;
} else {
} else if (options.includeJS) {
newPackage.module = "esm/index.js";
if (cjs) {
newPackage.main = "cjs/index.js";
Expand Down Expand Up @@ -255,7 +294,6 @@ export default async function main(customConfig) {

if (jsOut || cssOut) {
await writeMetaFile(esmOutput.result.metafile, outdir);

if (cssOut) {
relocateCSSToPackageRoot();
if (jsonResult) {
Expand Down
1 change: 1 addition & 0 deletions vuu-ui/scripts/esbuild.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export async function build(config) {
target = ["es2020", "chrome79"],
write = true,
} = config;

return esbuild({
entryPoints,
banner,
Expand Down
2 changes: 1 addition & 1 deletion vuu-ui/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"global.d.ts",
"packages/vuu-data-test/src/UpdateGenerator.ts",
"sample-apps/standalone-table/index.tsx"
],
, "packages/vuu-icons/index.ts" ],
"exclude": ["**/*.cy.*", "**/*.test.*"],
"references": [
{ "path": "packages/vuu-codemirror" },
Expand Down
Loading