#1074 fix bug when editing filters #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
commented
Jan 12, 2024
| @@ -207,7 +213,7 @@ export const ComboBox = forwardRef(function Combobox< | |||
| highlightedIndex={highlightedIndex} | |||
| itemTextHighlightPattern={String(inputProps.value) || undefined} | |||
| listHandlers={listHandlers} | |||
| onSelectionChange={onSelectionChange} | |||
| onSelectionChange={onSelectionChange} // not really needed, since onClick in listHandlers will be used instead. | |||
There was a problem hiding this comment.
@heswell let me know if I should get rid of this, I've checked onSelectionChange is not used if listHandlers is not undefined. And it is not undefined here since we use useList hook to get these for Combobox.
- onSelectionChange on ExpandoCombobox only gets called when a selection changes, which cause issues when someone tries to select the already selected item from the list dropdown. With this change I've provided a onListItemSelect handler which is same as onSelect on Lists. - Also, text selection used to `appear` blank in ExpandoCombobox because the background & text both used to change to white on selection. Changed the background color on selection to a shade of blue.
junaidzm13
force-pushed
the
1074-fix-edit-filter-bug
branch
from
fe18d5c to
f49eb81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onSelectionChangeonExpandoComboboxonly gets called when a selection changes, which cause issues when someone tries to select the already selected item from the list dropdown. With this change I've provided aonListItemSelecthandler which is same asonSelectonList.ExpandoComboboxbecause the background & text both used to change to white on selection. Changed the background color on selection to a shade of blue.