Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rearrange firebase admin pom deps #1066

Merged
merged 3 commits into from
Feb 3, 2025
Merged

chore: Rearrange firebase admin pom deps #1066

merged 3 commits into from
Feb 3, 2025

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jan 27, 2025

Following #1045

Changes:

@lahirumaramba lahirumaramba self-requested a review January 28, 2025 16:48
@jonathanedey jonathanedey added the release:stage Stage a release candidate label Jan 28, 2025
@jonathanedey jonathanedey removed the release:stage Stage a release candidate label Jan 29, 2025
@jonathanedey jonathanedey self-requested a review January 29, 2025 17:10
jonathanedey
jonathanedey approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks again Lawrence!

@jonathanedey jonathanedey merged commit c811733 into firebase:master Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanedey jonathanedey jonathanedey approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees

@jonathanedey jonathanedey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @jonathanedey