Allow StorageOptions to override storage host #1069
+74
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
To be able to use Firebase emulator and Firebase storage. I need to be able to override host.
Describe the solution you'd like
Allow us to pass StorageOption to FirebaseOption, to allow manually setting project id and host
This is discussed in #874 and would solve that issue by allowing us to set the host directly instead of trying to use a non-standard env variable that doesn't even work
@regine-chan submitted this commit in a PR #826 but it was abandoned, so I'm reviving the fix since we have a need