Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle/libs.versions.toml to specify the Android Gradle Plugin version #6321

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

dconeybe
Copy link
Contributor

Specifying the AGP version centrally in gradle/libs.versions.toml avoids duplicating the version number in multiple places.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

buildSrc Test Results

37 tests   37 ✔️  1m 5s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 6002848.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Unit Test Results

  1 033 files  +  1 017    1 033 suites  +1 017   36m 47s ⏱️ + 36m 34s
  5 810 tests +  5 703    5 788 ✔️ +  5 681  21 💤 +21  1 +1 
11 858 runs  +11 644  11 815 ✔️ +11 601  42 💤 +42  1 +1 

For more details on these failures, see this check.

Results for commit 6002848. ± Comparison against base commit e98a4b6.

♻️ This comment has been updated with latest results.

@dconeybe dconeybe marked this pull request as ready for review September 30, 2024 16:40
@dconeybe dconeybe merged commit 8e7f6a5 into main Sep 30, 2024
261 of 263 checks passed
@dconeybe dconeybe deleted the dconeybe/GradlePluginVersionIntoLibsVersionsToml branch September 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants