fixing nits

firebase · Aug 16, 2024 · a56adbd · a56adbd
1 parent 1a45154
commit a56adbd
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 58 deletions.
diff --git a/scripts/bin-test/sources/commonjs-grouped/index.js b/scripts/bin-test/sources/commonjs-grouped/index.js
@@ -38,10 +38,9 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
 });
-exports.extLocal2 = extLocal2;
 
 exports.g1 = require("./g1");
diff --git a/scripts/bin-test/sources/commonjs-main/functions.js b/scripts/bin-test/sources/commonjs-main/functions.js
@@ -37,8 +37,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
 });
-exports.extLocal2 = extLocal2;
diff --git a/scripts/bin-test/sources/commonjs-preserve/index.js b/scripts/bin-test/sources/commonjs-preserve/index.js
@@ -37,8 +37,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
   DO_BACKFILL: "False",
   LOCATION: "us-central1",
-});
-exports.extLocal2 = extLocal2;
+});
diff --git a/scripts/bin-test/sources/commonjs/index.js b/scripts/bin-test/sources/commonjs/index.js
@@ -37,8 +37,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
 });
-exports.extLocal2 = extLocal2;
diff --git a/spec/fixtures/sources/commonjs-grouped/index.js b/spec/fixtures/sources/commonjs-grouped/index.js
@@ -38,10 +38,9 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
 });
-exports.extLocal2 = extLocal2;
 
 exports.g1 = require("./g1");
diff --git a/spec/fixtures/sources/commonjs-main/functions.js b/spec/fixtures/sources/commonjs-main/functions.js
@@ -37,8 +37,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
-});
-exports.extLocal2 = extLocal2;
+});
diff --git a/spec/fixtures/sources/commonjs-parametrized-fields/index.js b/spec/fixtures/sources/commonjs-parametrized-fields/index.js
@@ -1,7 +1,5 @@
 const functions = require("../../../../src/v1/index");
 const functionsv2 = require("../../../../src/v2/index");
-const firestoreTranslateText = require("../../extsdk/translate").firestoreTranslateText;
-const backfill = require("../../extsdk/local").backfill;
 const params = require("../../../../src/params");
 params.clearParams();
 
@@ -30,27 +28,3 @@ exports.v2http = functionsv2.https.onRequest({
 }, (req, resp) => {
   resp.status(200).send("Hello world!");
 });
-
-// A Firebase extension by ref
-const extRef1 = firestoreTranslateText("extRef1", {
-  "COLLECTION_PATH": "collection1",
-  "INPUT_FIELD_NAME": "input1",
-  "LANGUAGES": "de,es",
-  "OUTPUT_FIELD_NAME": "translated",
-  "_EVENT_ARC_REGION": "us-central1",
-  "_FUNCTION_LOCATION": "us-central1",
-});
-exports.extRef1 = extRef1;
-
-// A Firebase function defined by extension event
-const ttOnStart = extRef1.onStart((event) => {
-  console.log("onStart got event: " + JSON.stringify(event, null, 2));
-});
-exports.ttOnStart = ttOnStart;
-
-// A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
-  DO_BACKFILL: "False",
-  LOCATION: "us-central1",
-});
-exports.extLocal2 = extLocal2;
diff --git a/spec/fixtures/sources/commonjs-params/index.js b/spec/fixtures/sources/commonjs-params/index.js
@@ -61,8 +61,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
   DO_BACKFILL: "False",
   LOCATION: "us-central1",
 });
-exports.extLocal2 = extLocal2;
diff --git a/spec/fixtures/sources/commonjs/index.js b/spec/fixtures/sources/commonjs/index.js
@@ -37,8 +37,7 @@ const ttOnStart = extRef1.onStart((event) => {
 exports.ttOnStart = ttOnStart;
 
 // A Firebase extension by localPath
-const extLocal2 = backfill("extLocal2", {
+exports.extLocal2 = backfill("extLocal2", {
     DO_BACKFILL: "False",
     LOCATION: "us-central1",
-});
-exports.extLocal2 = extLocal2;
+});
diff --git a/spec/runtime/loader.spec.ts b/spec/runtime/loader.spec.ts
@@ -437,6 +437,8 @@ describe("loadStack", () => {
             { name: "INT_PARAM", type: "int" },
             { name: "BOOLEAN_PARAM", type: "boolean" },
           ],
+          requiredAPIs: [],
+          extensions: {},
           endpoints: {
             v1http: {
               ...MINIMAL_V1_ENDPOINT,
@@ -463,19 +465,6 @@ describe("loadStack", () => {
               labels: {},
               httpsTrigger: {},
             },
-            ttOnStart: {
-              ...MINIMAL_V2_ENDPOINT,
-              entryPoint: "ttOnStart",
-              eventTrigger: {
-                channel: "projects/locations/us-central1/channels/firebase",
-                eventFilters: {},
-                eventType: "firebase.extensions.firestore-translate-text.v1.onStart",
-                retry: false,
-              },
-              labels: {},
-              platform: "gcfv2",
-              region: ["us-central1"],
-            },
           },
         },
       },