Add a test-only GitRepoLinks create command #7735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathu97
reviewed
Sep 26, 2024
kmcnellis
force-pushed
the
kianam-createconnection
branch
from
d5e86bd
to
f726078
Compare
kmcnellis
force-pushed
the
kianam-createconnection
branch
2 times, most recently
from
0cc2013
to
819a8fd
Compare
mathu97
reviewed
Sep 30, 2024
| utils.logBullet(clc.bold(`${clc.yellow("===")} Import a GitHub repository`)); | ||
|
|
||
| if (createConnectionId) { |
There was a problem hiding this comment.
would be great to add a unittest for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new command for testing, that allows creation of a new gitRepoLink, with a configurable connection ID. This allows us to test the flow for creating a DevConnect repo & test changing the linked repo via the REST api.
Mostly just moves around existing code in src/apphosting/githubConnections.ts, and allows for passing & testing a new parameter for the connection ID.
Scenarios Tested
Tested creating a backend to ensure it still works, and tested the new command
Sample Commands
firebase experiments:enable internaltesting
firebase apphosting:repos:create --project=kiana-firestack-bash --gitconnection=test-connection
firebase apphosting:repos:create --project=kiana-firestack-bash