Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #7789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Maintenance #7789

wants to merge 2 commits into from

Conversation

ifielker
Copy link
Contributor

@ifielker ifielker commented Oct 5, 2024

  • fixing some lint warnings
  • replacing some chained promises with async/await

src/emulator/auth/testing/helpers.ts Dismissed Show dismissed Hide dismissed
src/emulator/auth/testing/helpers.ts Dismissed Show dismissed Hide dismissed
@ifielker ifielker requested a review from joehan October 5, 2024 01:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 27.36842% with 69 lines in your changes missing coverage. Please review.

Project coverage is 51.05%. Comparing base (7ab6507) to head (b9995c6).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/emulator/functionsEmulator.ts 0.00% 23 Missing ⚠️
src/extensions/runtimes/node.ts 24.00% 19 Missing ⚠️
src/error.ts 30.76% 8 Missing and 1 partial ⚠️
src/extensions/extensionsApi.ts 50.00% 4 Missing and 4 partials ⚠️
src/extensions/runtimes/common.ts 38.46% 8 Missing ⚠️
src/extensions/types.ts 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7789      +/-   ##
==========================================
- Coverage   51.12%   51.05%   -0.08%     
==========================================
  Files         418      419       +1     
  Lines       28908    28990      +82     
  Branches     5910     5933      +23     
==========================================
+ Hits        14779    14800      +21     
- Misses      12814    12872      +58     
- Partials     1315     1318       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants