fix(js): test on node versions 20 through 22; 23 is currently broken #…

…1995 ISSUE: #1995 CHANGELOG: - [ ] Update biome configuration to use arrow parens always. - [ ] Update github workflows to test on node versions 20 through 22. - [ ] We will add version #23 post fixes. - [ ] Set node 22 to be the default for our eng workstations in the setup script for now.
firebase · Feb 15, 2025 · 4ad73bc · 4ad73bc
1 parent d1b4be5
commit 4ad73bc
Show file tree

Hide file tree

Showing 15 changed files with 75 additions and 168 deletions.
diff --git a/.github/workflows/builder.yml b/.github/workflows/builder.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Build Check (Run npm run build everywhere locally if this fails)
 
@@ -22,21 +11,24 @@ env:
 
 jobs:
   build:
-    name: Run build tasks
+    name: Run build tasks (Node ${{ matrix.node-version }})
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['20', '21', '22']
     steps:
-    - uses: actions/checkout@v3
-    - uses: pnpm/action-setup@v3
-    - name: Set up node v20
-      uses: actions/setup-node@v4
-      with:
-        node-version: 20.x
-        cache: pnpm
-    - name: Install dependencies
-      run: pnpm install
-    - name: Run build script
-      run: pnpm build
-    - name: Run js tests
-      run: pnpm test:js
-    - name: Validate working directory is clean
-      run: .github/workflows/scripts/ensure-clean-working-tree.sh
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v3
+      - name: Set up node v${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: pnpm
+      - name: Install dependencies
+        run: pnpm install
+      - name: Run build script
+        run: pnpm build
+      - name: Run js tests
+        run: pnpm test:js
+      - name: Validate working directory is clean
+        run: .github/workflows/scripts/ensure-clean-working-tree.sh
diff --git a/.github/workflows/bump-cli-version.yml b/.github/workflows/bump-cli-version.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Bump and Tag CLI Version
 

diff --git a/.github/workflows/bump-js-version.yml b/.github/workflows/bump-js-version.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Bump and Tag JS Version
 

diff --git a/.github/workflows/bump-package-version.yml b/.github/workflows/bump-package-version.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Bump Version for a package
 

diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Run e2e tests
 
@@ -21,15 +10,18 @@ on:
 
 jobs:
   build:
-    name: Run e2e tests
+    name: Run e2e tests (Node ${{ matrix.node-version }})
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['20', '21', '22']
     steps:
       - uses: actions/checkout@v3
       - uses: pnpm/action-setup@v3
-      - name: Set up node v20
+      - name: Set up node v${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
-          node-version: 20.x
+          node-version: ${{ matrix.node-version }}
           cache: pnpm
       - name: Install dependencies
         run: pnpm install

diff --git a/.github/workflows/formatter.yml b/.github/workflows/formatter.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Formatting Check (Run npm run format locally if this fails)
 

diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Go tests and checks
 

diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         python-version:
-          - "3.12"
+          - "3.12" # uv manages versions; this is base.
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/release_js_main.yml b/.github/workflows/release_js_main.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Release Genkit JS
 

diff --git a/.github/workflows/samples.yml b/.github/workflows/samples.yml
@@ -1,20 +1,9 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Build Samples (only runs if /samples/** is changed)
 
-on: 
+on:
   pull_request:
     paths: samples/**
 
@@ -24,19 +13,22 @@ env:
 
 jobs:
   build:
-    name: Build Samples
+    name: Build Samples (Node ${{ matrix.node-version }})
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['20', '21', '22']
     steps:
-    - uses: actions/checkout@v3
-    - uses: pnpm/action-setup@v3
-    - name: Set up node v20
-      uses: actions/setup-node@v4
-      with:
-        node-version: 20.x
-        cache: pnpm
-    - name: Install dependencies
-      run: pnpm install
-    - name: Build Samples
-      run: pnpm build:js-samples
-    - name: Validate working directory is clean
-      run: .github/workflows/scripts/ensure-clean-working-tree.sh
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v3
+      - name: Set up node v${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: pnpm
+      - name: Install dependencies
+        run: pnpm install
+      - name: Build Samples
+        run: pnpm build:js-samples
+      - name: Validate working directory is clean
+        run: .github/workflows/scripts/ensure-clean-working-tree.sh
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,16 +1,5 @@
 # Copyright 2024 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
 
 name: Run Tests
 
@@ -24,15 +13,18 @@ jobs:
   build:
     name: Run Tests (just DevUI tests for now)
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['20', '21', '22']
     steps:
-    - uses: actions/checkout@v3
-    - uses: pnpm/action-setup@v3
-    - name: Set up node v20
-      uses: actions/setup-node@v4
-      with:
-        node-version: 20.x
-        cache: pnpm
-    - name: Install dependencies and build
-      run: pnpm build:genkit-tools
-    - name: Run tests
-      run: pnpm test:genkit-tools
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v3
+      - name: Set up node v${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}.x # Use matrix variable
+          cache: pnpm
+      - name: Install dependencies and build
+        run: pnpm build:genkit-tools
+      - name: Run tests
+        run: pnpm test:genkit-tools
diff --git a/bin/add_license b/bin/add_license
@@ -42,6 +42,7 @@ $HOME/go/bin/addlicense \
   -ignore '**/dist/**/*' \
   -ignore '**/node_modules/**/*' \
   -ignore '**/pnpm-lock.yaml' \
+  -ignore '**/py/site/**/*.html' \
   -ignore '.nx/**/*' \
   -ignore '.trunk/**/*' \
   "$TOP_DIR"
diff --git a/bin/check_license b/bin/check_license
@@ -45,6 +45,7 @@ $HOME/go/bin/addlicense \
   -ignore '**/dist/**/*' \
   -ignore '**/node_modules/**/*' \
   -ignore '**/pnpm-lock.yaml' \
+  -ignore '**/py/site/**/*.html' \
   -ignore '.nx/**/*' \
   -ignore '.trunk/**/*' \
   "$TOP_DIR"
diff --git a/bin/setup b/bin/setup
@@ -24,7 +24,7 @@ fi
 TOP_DIR=$(git rev-parse --show-toplevel)
 
 PNPM_VERSION="10.2.0"
-NODE_VERSION="23"
+NODE_VERSION="22" # See: https://github.com/firebase/genkit/issues/1995
 NVM_VERSION="0.40.1"
 
 AUDIENCE="eng"

diff --git a/biome.json b/biome.json
@@ -31,7 +31,10 @@
       ".nx/**",
       ".trunk/**",
       "bazel-*/**",
+      "genkit-tools/genkit-schema.json",
+      "go/**",
       "node_modules/**",
+      "py/**",
       "third_party/**"
     ]
   },
@@ -46,7 +49,7 @@
   },
   "javascript": {
     "formatter": {
-      "arrowParentheses": "asNeeded",
+      "arrowParentheses": "always",
       "attributePosition": "auto",
       "bracketSpacing": true,
       "jsxQuoteStyle": "double",