Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize to type/provider/name pattern for action names. #324

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

randall77
Copy link
Contributor

Tools were not working because they were being inserted as
tool/tool/name and looked up as tool/name/name.

Tools were not working because they were being inserted as
tool/tool/name and looked up as tool/name/name.
@randall77 randall77 requested a review from ianlancetaylor June 4, 2024 21:05
@jba
Copy link
Contributor

jba commented Jun 4, 2024

Thanks, I probably broke this when I did my "Define" reorg.
I still don't understand why some components take a provider and some do not. But as long as we match the JS I'm fine.

@jba jba self-requested a review June 4, 2024 21:17
@randall77
Copy link
Contributor Author

I don't know that we're matching the js. I just tried to make the Go part self-consistent.
It's always actiontype/provider/name. In some cases where we don't have a provider I used "local" as the provider, like for tools. DocumentStore is also weird. It has providers for each of its sub-indexer and sub-retreiver, but has no provider itself.

@randall77 randall77 merged commit 92c65d4 into main Jun 4, 2024
5 checks passed
@randall77 randall77 deleted the khr-work21 branch June 4, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants