Merge pull request #43 from firebase/jw-node-fix

Fixed Node bug which caused GeoFire not to work
firebase · Sep 4, 2014 · 20f103b · 20f103b
2 parents 0e0338e + 6bb29e9
commit 20f103b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/build/header b/build/header
@@ -12,7 +12,9 @@
 
 // Include RSVP if this is being run in node
 if (typeof module !== "undefined" && typeof process !== "undefined") {
-  var Firebase = require("firebase");
+  // We need this `Firebase || require("firebase")` hack to get GeoFire to work properly in Node.js
+  // since otherwise, checking for `instanceof Firebase` fails.
+  var Firebase = Firebase || require("firebase");
   var RSVP = require("rsvp");
 }
 

diff --git a/changelog.txt b/changelog.txt
@@ -1 +1,2 @@
 fixed - Fixed bug which caused the `ready` event to not fire in some edge cases when a `GeoQuery` was updated (thanks to @mikepugh for the fix).
+fixed - Fixed bug which prevented GeoFire from working in Node.js.
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		fixed - Fixed bug which caused the `ready` event to not fire in some edge cases when a `GeoQuery` was updated (thanks to @mikepugh for the fix).
		fixed - Fixed bug which prevented GeoFire from working in Node.js.