Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return query result from hook #43

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

stepansergeevitch
Copy link
Collaborator

Removed our custom run implementation in favor of the default airflow implementation, which works just fine and has results returned out of the box

@stepansergeevitch stepansergeevitch self-assigned this Jan 9, 2025
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner January 9, 2025 12:58
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that lgtm

tests/hooks/test_firebolt.py Outdated Show resolved Hide resolved
@stepansergeevitch stepansergeevitch merged commit ba5a9f6 into main Jan 13, 2025
6 checks passed
@stepansergeevitch stepansergeevitch deleted the FIR-42241-airflow-hook-allow-returning-result branch January 13, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants