feat: FIR-42244 airflow allow passing query timeout #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Jan 14, 2025
| @@ -137,6 +143,8 @@ def __init__( | |||
| self.firebolt_conn_id = firebolt_conn_id | |||
| self.engine_name = engine_name | |||
| self.database = None | |||
| self.query_timeout = None | |||
| self.fail_on_query_timeout = False | |||
There was a problem hiding this comment.
Should this be True by default?
There was a problem hiding this comment.
I think it doesn't matter since we won't support engine start/stop timeout here so it will not be accounted for. I can set it to true
There was a problem hiding this comment.
Let's set it to true just to avoid confusion, users might see it and have questions why can't they fail if something goes wrong. If there's any timeout behind the scenes (e.g. network disconnect or something) we'll propagate it.
stepansergeevitch
changed the title
stepansergeevitch
changed the title
|
stepansergeevitch
deleted the
FIR-42244-airflow-allow-passing-query-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to pass timeout to firebolt operator and hook