Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FIR-34986): can use COPY to create table #131

Merged
merged 12 commits into from
Aug 15, 2024
Merged

feat(FIR-34986): can use COPY to create table #131

merged 12 commits into from
Aug 15, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Aug 2, 2024

Description

Adding ability to use copy command instead of external table. Copy is more efficient and will be supported for longer.
To maintain backwards-compatibility by default dbt-firebolt uses external table and if the users specify strategy: copy in their sources file then copy is used.

Also adding fixes for project installation as tests broke due to dbt-firebolt not being installed in the right directory.
Changes in adapter and catalog files are necessary since external tables weren't picked up before by the DBT's changes resolution mechanism and -full-refresh parameter would write duplicate data.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@ptiurin ptiurin changed the title Feat-add-copy feat(FIR-34986): can use COPY to create table Aug 2, 2024
Copy link

@ptiurin ptiurin marked this pull request as ready for review August 15, 2024 09:17
@ptiurin ptiurin requested a review from a team as a code owner August 15, 2024 09:17
@ptiurin ptiurin merged commit ca1e3ab into main Aug 15, 2024
7 checks passed
@ptiurin ptiurin deleted the feat-add-copy branch August 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants