feat(FIR-29284): dbt 1.7 support #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stepansergeevitch
approved these changes
Aug 23, 2024
| @@ -183,90 +183,6 @@ | |||
| {{ return(info_table) }} | |||
| {% endmacro %} | |||
|
|
|||
|
|
|||
| {% macro firebolt__create_table_as(temporary, | |||
There was a problem hiding this comment.
Why don't we need these anymore? Can we use the default dbt implementation now?
There was a problem hiding this comment.
They've a part of the big dbt refactor. Now this (as well as the view macros) live in their respective subdirectories. e.g. dbt/include/firebolt/macros/relations/table/create.sql instead of everything living in the adapters.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #111
Description
Update the connector to be compatible with dbt 1.7:
Checklist
changie newand committed everything in .changes folder