Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip incompatible tests #136

Merged
merged 2 commits into from
Aug 28, 2024
Merged

test: Skip incompatible tests #136

merged 2 commits into from
Aug 28, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Aug 28, 2024

Description

These tests rely on columns being nullable by default. We'll have to skip them for FB 1.0.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@ptiurin ptiurin marked this pull request as ready for review August 28, 2024 11:06
@ptiurin ptiurin requested a review from a team as a code owner August 28, 2024 11:06
Copy link

@ptiurin ptiurin merged commit 4967c48 into main Aug 28, 2024
5 checks passed
@ptiurin ptiurin deleted the test-skip-failures branch August 28, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants