-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FIR-35169): dbt 1.8 support #137
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question
raise dbt.exceptions.NotImplementedError( | ||
'`cancel` is not implemented for this adapter!' | ||
) | ||
raise NotImplementedError('`cancel` is not implemented for this adapter!') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one about reverting the last operation or about canceling the ongoing query? Can we implement this if latter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is about cancelling the last executed query. As discussed, we can do it in a roundabout way by sending a termination signal to a process that's running a query, but this is a very ugly approach to it and I'm not even sure if there's an interest in using this method. It's very niche in the context of DBT.
For reference, postgres and snowflake implementations have a server-side cancel here.
Resolves #124
Description
DBT 1.8 support with refactors required and new tests. Some imports have changed as well as interfaces.
We no longer need to pin the dbt-core version, but need to make sure dbt-adapters module is included.
Checklist
changie new
and committed everything in .changes folder