Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FIR-35169): dbt 1.8 support #137

Merged
merged 3 commits into from
Sep 2, 2024
Merged

feat(FIR-35169): dbt 1.8 support #137

merged 3 commits into from
Sep 2, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Aug 30, 2024

Resolves #124

Description

DBT 1.8 support with refactors required and new tests. Some imports have changed as well as interfaces.
We no longer need to pin the dbt-core version, but need to make sure dbt-adapters module is included.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@ptiurin ptiurin mentioned this pull request Aug 30, 2024
8 tasks
@ptiurin ptiurin changed the title dbt 1.8 support feat(FIR-35169): dbt 1.8 support Aug 30, 2024
Copy link

@ptiurin ptiurin marked this pull request as ready for review August 30, 2024 13:15
@ptiurin ptiurin requested a review from a team as a code owner August 30, 2024 13:15
Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

raise dbt.exceptions.NotImplementedError(
'`cancel` is not implemented for this adapter!'
)
raise NotImplementedError('`cancel` is not implemented for this adapter!')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one about reverting the last operation or about canceling the ongoing query? Can we implement this if latter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is about cancelling the last executed query. As discussed, we can do it in a roundabout way by sending a termination signal to a process that's running a query, but this is a very ugly approach to it and I'm not even sure if there's an interest in using this method. It's very niche in the context of DBT.
For reference, postgres and snowflake implementations have a server-side cancel here.

@ptiurin ptiurin merged commit ff53c82 into main Sep 2, 2024
8 checks passed
@ptiurin ptiurin deleted the dbt-1.8 branch September 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to support dbt-core v1.8.0
2 participants