Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed links, added link check #208

Merged
merged 3 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Check PR before merge
on:
pull_request:
branches:
- gh-pages

jobs:
check-links:
# The check is advisory. It won't prevent merge even if it's broken
continue-on-error: true
# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
contents: read
issues: read
# permission needed to post a comment on the PR
pull-requests: write

runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Check there are no 404 links
id: check404
run: |
set -xeuo pipefail
result_file=$(mktemp)
set +e
scripts/check-links.sh > "$result_file"
rv=$?
set -e
if [[ "$rv" != 0 ]]; then
cat "$result_file"
{
# Abusing the unique name of the file as an EOF marker
echo "output<<$result_file"
cat "$result_file"
echo "$result_file"
} >> $GITHUB_OUTPUT
fi
exit "$rv"

- name: Find Comment
id: fc
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e # v3.1.0
if: always()
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: "github-actions[bot]"
body-includes: "Link Check Status:"

- name: Post a comment on failure
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
if: failure()
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: |
# $\color{red}{\text{🧨 Link Check Status: FAILURE}}$
```
${{ steps.check404.outputs.output }}
```
edit-mode: replace

- name: Post a comment on success
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
if: success()
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: |
# $\color{green}{\text{👍 Link Check Status: SUCCESS}}$
thumbs up guy meme
edit-mode: replace
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
.github/workflows/
.idea/
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
start-local:
scripts/start-local.sh

check-links:
scripts/check-links.sh
4 changes: 4 additions & 0 deletions docs/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin]

# Site quality checker
gem "html-proofer"
gem 'rake'
gem "webrick", "~> 1.8"

gem "activesupport", ">= 6.1.7.5"
57 changes: 32 additions & 25 deletions docs/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (6.0.6.1)
activesupport (6.1.7.5)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
addressable (2.8.5)
public_suffix (>= 2.0.2, < 6.0)
base64 (0.1.1)
Expand All @@ -16,7 +16,7 @@ GEM
coffee-script-source (1.11.1)
colorator (1.1.0)
commonmarker (0.23.10)
concurrent-ruby (1.2.0)
concurrent-ruby (1.2.2)
dnsruby (1.61.9)
simpleidn (~> 0.1)
em-websocket (0.5.3)
Expand All @@ -34,12 +34,12 @@ GEM
ffi (1.15.5)
forwardable-extended (2.6.0)
gemoji (3.0.1)
github-pages (226)
github-pages (228)
github-pages-health-check (= 1.17.9)
jekyll (= 3.9.2)
jekyll (= 3.9.3)
jekyll-avatar (= 0.7.0)
jekyll-coffeescript (= 1.1.1)
jekyll-commonmark-ghpages (= 0.2.0)
jekyll-commonmark-ghpages (= 0.4.0)
jekyll-default-layout (= 0.1.4)
jekyll-feed (= 0.15.1)
jekyll-gist (= 1.5.0)
Expand Down Expand Up @@ -73,10 +73,10 @@ GEM
jemoji (= 0.12.0)
kramdown (= 2.3.2)
kramdown-parser-gfm (= 1.1.0)
liquid (= 4.0.3)
liquid (= 4.0.4)
mercenary (~> 0.3)
minima (= 2.5.1)
nokogiri (>= 1.13.4, < 2.0)
nokogiri (>= 1.13.6, < 2.0)
rouge (= 3.26.0)
terminal-table (~> 1.4)
github-pages-health-check (1.17.9)
Expand All @@ -97,13 +97,13 @@ GEM
typhoeus (~> 1.3)
yell (~> 2.0)
http_parser.rb (0.8.0)
i18n (0.9.5)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
jekyll (3.9.2)
jekyll (3.9.3)
addressable (~> 2.4)
colorator (~> 1.0)
em-websocket (~> 0.5)
i18n (~> 0.7)
i18n (>= 0.7, < 2)
jekyll-sass-converter (~> 1.0)
jekyll-watch (~> 2.0)
kramdown (>= 1.17, < 3)
Expand All @@ -119,11 +119,11 @@ GEM
coffee-script-source (~> 1.11.1)
jekyll-commonmark (1.4.0)
commonmarker (~> 0.22)
jekyll-commonmark-ghpages (0.2.0)
commonmarker (~> 0.23.4)
jekyll-commonmark-ghpages (0.4.0)
commonmarker (~> 0.23.7)
jekyll (~> 3.9.0)
jekyll-commonmark (~> 1.4.0)
rouge (>= 2.0, < 4.0)
rouge (>= 2.0, < 5.0)
jekyll-default-layout (0.1.4)
jekyll (~> 3.0)
jekyll-feed (0.15.1)
Expand Down Expand Up @@ -211,7 +211,7 @@ GEM
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
liquid (4.0.3)
liquid (4.0.4)
listen (3.7.1)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
Expand All @@ -220,10 +220,12 @@ GEM
jekyll (>= 3.5, < 5.0)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
minitest (5.17.0)
minitest (5.19.0)
nokogiri (1.16.5-arm64-darwin)
racc (~> 1.4)
nokogiri (1.16.5-x86_64-linux)
racc (~> 1.4)
octokit (4.25.1)
octokit (4.23.0)
faraday (>= 1, < 3)
sawyer (~> 0.9)
parallel (1.22.1)
Expand All @@ -232,6 +234,7 @@ GEM
public_suffix (4.0.7)
racc (1.7.3)
rainbow (3.1.1)
rake (13.0.6)
rb-fsevent (0.11.1)
rb-inotify (0.10.1)
ffi (~> 1.0)
Expand All @@ -254,29 +257,33 @@ GEM
strscan (3.1.0)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thread_safe (0.3.6)
typhoeus (1.4.0)
ethon (>= 0.9.0)
tzinfo (1.2.10)
thread_safe (~> 0.1)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unf (0.1.4)
unf_ext
unf_ext (0.0.8.2)
unicode-display_width (1.8.0)
webrick (1.8.1)
yell (2.2.2)
zeitwerk (2.6.6)
zeitwerk (2.6.11)

PLATFORMS
arm64-darwin-21
x86_64-linux

DEPENDENCIES
activesupport (>= 6.1.7.5)
github-pages
html-proofer
jekyll-feed (~> 0.12)
jekyll-seo-tag
rake
tzinfo (~> 1.2)
tzinfo-data
wdm (~> 0.1.1)
webrick (~> 1.8)

BUNDLED WITH
2.2.31
2.4.13
4 changes: 2 additions & 2 deletions docs/developing-with-firebolt/firebolt-rest-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@ This returns (`...` indicates areas of JSON omitted from this example):

Ingesting data using the Firebolt REST API requires the following steps:

1. [Create an external table](./firebolt-rest-api.html/#create-an-external-table)
2. [Create a fact table and import data](./firebolt-rest-api.html/#create-a-fact-table-and-import-data)
1. [Create an external table](#create-an-external-table)
2. [Create a fact table and import data](#create-a-fact-table-and-import-data)

### Create an external table

Expand Down
2 changes: 1 addition & 1 deletion docs/general-reference/data-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ For historic reasons, if you set the setting `standard_conforming_strings` to `f
>If you worked with Firebolt before DB version 3.22, you might still be using the legacy date and timestamp types.
>Determine which types you are using by executing the query `SELECT EXTRACT(CENTURY FROM DATE '2023-03-16');`.
>If this query returns a result, you are using the redesigned date and timestamp types and can continue with this documentation.
>If this query returns an error, you are using the legacy date and timestamp types and can find [legacy documentation here](legacy-date-timestamp.md), or instructions to reingest your data to use the new types [here](../release-notes/release-notes-archive.html#db-version-322).
>If this query returns an error, you are using the legacy date and timestamp types and can find [legacy documentation here](legacy-date-timestamp.md), or instructions to reingest your data to use the new types [here](./release-notes/release-notes-archive.md#db-version-322).

Firebolt supports three date and timestamp data types:

Expand Down
2 changes: 1 addition & 1 deletion docs/general-reference/date-data-type.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This topic describes the Firebolt implementation of the `DATE` data type.
>If you worked with Firebolt before DB version 3.22, you might still be using the legacy date and timestamp types.
>Determine which types you are using by executing the query `SELECT EXTRACT(CENTURY FROM DATE '2023-03-16');`.
>If this query returns a result, you are using the redesigned date and timestamp types and can continue with this documentation.
>If this query returns an error, you are using the legacy date and timestamp types and can find [legacy documentation here](legacy-date-timestamp.md), or instructions to reingest your data to use the new types [here](../release-notes/release-notes-archive.html#db-version-322).
>If this query returns an error, you are using the legacy date and timestamp types and can find [legacy documentation here](legacy-date-timestamp.md), or instructions to reingest your data to use the new types [here](./release-notes/release-notes-archive.md#db-version-322).

* Topic ToC
{:toc}
Expand Down
Loading
Loading