driver that can connect to both versions 1 and 2 #293
Conversation
alexradzin
force-pushed
the
both-identities3
branch
from
9ebc686 to
54823cf
Compare
|
Document can be found here. |
src/main/java/com/firebolt/jdbc/connection/settings/FireboltProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionUserPasswordAuthentication.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/client/account/FireboltAccountRetriever.java
Show resolved
Hide resolved
...ain/java/com/firebolt/jdbc/client/authentication/OldServiceAccountAuthenticationRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionServiceSecretAuthentication.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionServiceSecretAuthentication.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionServiceSecretAuthentication.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionUserPasswordAuthentication.java
Outdated
Show resolved
Hide resolved
src/main/java/com/firebolt/jdbc/connection/settings/FireboltProperties.java
Outdated
Show resolved
Hide resolved
| run-v1: | ||
| description: 'Run tests against Firebolt DB v1' | ||
| required: true | ||
| default: true | ||
| type: choice | ||
| options: | ||
| - 'true' | ||
| - 'false' | ||
| run-v2: | ||
| description: 'Run tests against Firebolt DB v2' | ||
| required: true | ||
| default: true | ||
| type: choice | ||
| options: | ||
| - 'true' | ||
| - 'false' |
There was a problem hiding this comment.
You can add workflow_dispatch section to V1 and V2 workflows to make them individually callable alongside the shared workflow. This way you don't need to have those input parameters.
|
Kudos, SonarCloud Quality Gate passed!
|
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionServiceSecret.java
Outdated
Show resolved
Hide resolved
| .compress(false) | ||
| .accountId(accountId) | ||
| .host(UrlUtil.createUrl(systemEngineEndpoint).getHost()) | ||
| .build(); |
There was a problem hiding this comment.
Here, we don't set the database. Do we set it elsewhere?
There was a problem hiding this comment.
Sure. Here we update initial loginPorperties where all initially provided properties are updated (including DB if it has been supplied). The only reason of this code is to override some properties, e.g. systemEngine=true (because this is system engine), corepress=false (because system engine cannot compress data) etc.
src/main/java/com/firebolt/jdbc/connection/FireboltConnectionServiceSecret.java
Outdated
Show resolved
Hide resolved
alexradzin
force-pushed
the
both-identities3
branch
from
566e64b to
c73cb0c
Compare
alexradzin
force-pushed
the
both-identities3
branch
from
c73cb0c to
0adb87b
Compare
alexradzin
changed the base branch from
feature/FIR-21173-new-identity-support
to
master
No description provided.