Fir 32148 resultset getters case insensitive #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2024 18:46
alexradzin
force-pushed
the
FIR-32148-resultset-getters-case-insensitive
branch
from
e05d352 to
1175c06
Compare
|
ptiurin
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Is this a result of rebase going wrong? Let's make sure this is corrected before merge.
Comment on lines
+178
to
+179
| String catalogClause = catalog == null ? null : format("%s LIKE '%s'", TABLE_CATALOG, catalog); | ||
| String schemaClause = schemaPattern == null ? null : format("TABLE_SCHEMA LIKE '%s'", schemaPattern); |
There was a problem hiding this comment.
Should TABLE_SCHEMA also be a constant like TABLE_CATALOG?
Comment on lines
+181
to
+183
| if (where.isEmpty()) { | ||
| where = " WHERE " + where; | ||
| } |
There was a problem hiding this comment.
Should this if be an inverse instead? Otherwise if where is empty we're creating a broken SQL.
| int n = rsmd.getColumnCount(); | ||
| for (int i = 1; i <= n; i++) { | ||
| String columnName = rsmd.getColumnName(i); | ||
| System.out.println(columnName + ", " + rsmd.getColumnType(i)); |
There was a problem hiding this comment.
Let's not print in tests to avoid unnecessary output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.