FIR-32016, FIR-32018: implemented blob, clob, stream in PS #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Apr 18, 2024
| @@ -27,4 +28,17 @@ public void readAllBytes(@Nullable InputStream is) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public String read(Reader initialReader, int limit) throws IOException { | |||
| char[] arr = new char[8 * 1024]; | |||
There was a problem hiding this comment.
Let's have this as a constant.
There was a problem hiding this comment.
Let's add integration tests as well to cover these types.
alexradzin
force-pushed
the
FIR-32016_FIR-32018-ps-blob-clob-stream
branch
from
804357d to
79cd5a4
Compare
ptiurin
approved these changes
Apr 22, 2024
…n prepared statement
alexradzin
force-pushed
the
FIR-32016_FIR-32018-ps-blob-clob-stream
branch
from
7666584 to
955ccd7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob, clob and stream related methods in prepared statement