Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIR-33264: quoted engine and DB names #417

Merged
merged 3 commits into from
May 28, 2024
Merged

FIR-33264: quoted engine and DB names #417

merged 3 commits into from
May 28, 2024

Conversation

alexradzin
Copy link
Collaborator

No description provided.

@alexradzin alexradzin requested a review from a team as a code owner May 28, 2024 10:08
@alexradzin alexradzin force-pushed the FIR-33264-quoute-engine-database branch from 69dacef to 5377f04 Compare May 28, 2024 10:31
stepansergeevitch
stepansergeevitch reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for v2 which

  • Creates an engine with uppercase letters in names
  • Tries to connect to it
    Otherwise LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexradzin alexradzin merged commit 905a037 into master May 28, 2024
4 checks passed
@alexradzin alexradzin deleted the FIR-33264-quoute-engine-database branch May 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexradzin @stepansergeevitch