Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix unit tests when run locally from Mac OS #465

Merged
merged 1 commit into from
Oct 21, 2024
+2 −1
Merged

test: Fix unit tests when run locally from Mac OS #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/test/java/com/firebolt/jdbc/client/UserAgentFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ public static String userAgent(String format) {
}

public static String userAgent(String format, String driverVersion, String javaVersion, String osName, String osVersion) {
return String.format(format, driverVersion, javaVersion, osName, osVersion);
// Mac OS is renamed to Darwin in the user agent string
return String.format(format, driverVersion, javaVersion, osName, osVersion).replace("Mac OS X", "Darwin");
}

public static String osName() {
Expand Down
Loading