fix: Allow boolean values in variables (#1302)

See <https://gitlab.com/gitlab-org/gitlab/-/issues/21587#note_2016187568>.
firecow · Jul 26, 2024 · 9016d6f · 9016d6f
1 parent 52b231f
commit 9016d6f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 32 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -138,7 +138,7 @@ export class Parser {
                 let value = _value;
                 if (value === null) value = ""; // variable's values are nullable
                 assert(
-                    typeof value === "string" || typeof value === "number",
+                    typeof value === "string" || typeof value === "number" || typeof value === "boolean",
                     chalk`{blueBright ${jobName}} has invalid variables hash of key value pairs. ${key}=${value}`
                 );
                 jobData.variables[key] = String(value);
@@ -148,7 +148,7 @@ export class Parser {
                 const service = jobData.services[i];
                 for (const [key, value] of Object.entries(service.variables || {})) {
                     assert(
-                        typeof value === "string" || typeof value === "number",
+                        typeof value === "string" || typeof value === "number" || typeof value === "boolean",
                         chalk`{blueBright ${jobName}.services[${i}]} has invalid variables hash of key value pairs. ${key}=${value}`
                     );
                     jobData.services[i].variables[key] = String(value);

diff --git a/tests/test-cases/invalid-variables-bool/.gitlab-ci.yml b/tests/test-cases/invalid-variables-bool/.gitlab-ci.yml
diff --git a/tests/test-cases/invalid-variables-bool/integration.invalid-variables-bool.test.ts b/tests/test-cases/invalid-variables-bool/integration.invalid-variables-bool.test.ts