feat: support absolute path for options that makes sense #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANGkeith
force-pushed
the
feat/decouple-from-cwd
branch
4 times, most recently
from
85e258e
to
4ec2036
Compare
ANGkeith
force-pushed
the
feat/decouple-from-cwd
branch
from
4ec2036
to
82f0916
Compare
ANGkeith
changed the title
ANGkeith
changed the title
ANGkeith
force-pushed
the
feat/decouple-from-cwd
branch
from
82f0916
to
8e0c3c2
Compare
|
@ANGkeith Should we put this on the 5.x.x roadmap? Or do you think developers can handle it in a 4.x.x release? |
ok let's go with this.. don't want to make any enemies... haha possible to make a major release soon ? This mr touches too much file.. don't really want to leave it lying around for too long haha |
|
Yeah, I'm creating a 5.x.x branch, lets work on that the next couple of weeks. |
ANGkeith
force-pushed
the
feat/decouple-from-cwd
branch
from
8e0c3c2
to
6708d10
Compare
ANGkeith
force-pushed
the
feat/decouple-from-cwd
branch
from
6708d10
to
8bca3be
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1067
with this implementation,
we should be able to prevent gcl's
stateDirfrom polluting the repo withBreaking changes
--homenow only supports absolute path.gitlab-ci.localis no longer hard-coded into--homehttps://github.com/firecow/gitlab-ci-local/pull/1360/files#diff-fb0d62c1e19bd1befd6116026defbd560b8edf9e2cdf3cab5280519cd10c3927R50