Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <gclShellPromptPlaceholder> appearing in interactive job output #1440

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: <gclShellPromptPlaceholder> appearing in interactive job output #1440

merged 1 commit into from
Dec 1, 2024

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Nov 28, 2024 •
edited
Loading

closes #1437

currently, the interactive job output is send to stdout directly instead of writestream so might be slightly more tricky to write the unit test... and hence i am leaving that out

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

firecow
firecow approved these changes Dec 1, 2024
View reviewed changes
Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a unit test of this is difficult, this is fine

@firecow firecow merged commit 3274679 into master Dec 1, 2024
10 checks passed
@firecow firecow deleted the fix/#1437 branch December 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecow firecow firecow approved these changes

Assignees

@firecow firecow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive job output broken
2 participants
@ANGkeith @firecow