Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DIRK-IMEX schemes #106

Merged
merged 27 commits into from
Jan 14, 2025
Merged

Add DIRK-IMEX schemes #106

merged 27 commits into from
Jan 14, 2025

Conversation

ScottMacLachlan
Copy link
Collaborator

This adds an implementation of the DIRK-IMEX method from the Ascher-Ruuth-Spiteri 1997 Applied Numerical Mathematics paper. Mostly this layers the IMEX part on top of the existing DIRK code (but is different enough that reuse is not feasible).

rckirby
rckirby requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is lookling really good! I guess comparisons between DIRKIMEX + FIRK are on the "to-do" list.

demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Outdated Show resolved Hide resolved
demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Outdated Show resolved Hide resolved
demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Outdated Show resolved Hide resolved
demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Outdated Show resolved Hide resolved
demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Show resolved Hide resolved
irksome/dirk_imex_tableaux.py Outdated Show resolved Hide resolved
irksome/imex.py Outdated Show resolved Hide resolved
irksome/imex.py Show resolved Hide resolved
irksome/imex.py Show resolved Hide resolved
tests/test_imex.py Outdated Show resolved Hide resolved
rckirby
rckirby requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Not sure what to do yet about lacking the optimization from Spiteri's paper.

irksome/imex.py Show resolved Hide resolved
irksome/imex.py Show resolved Hide resolved
irksome/stepper.py Outdated Show resolved Hide resolved
rckirby
rckirby approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to making sure that our two flavors of IMEX are consistent, looks good to me!

demos/monodomain/demo_monodomain_FHN_dirkimex.py.rst Outdated Show resolved Hide resolved
@rckirby rckirby merged commit bfd9468 into master Jan 14, 2025
2 checks passed
@rckirby rckirby deleted the smaclachlan/add_dirk_imex branch January 14, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby rckirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottMacLachlan @rckirby