Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify TimeStepper interface #122

Merged
merged 70 commits into from
Mar 3, 2025
Merged

Unify TimeStepper interface #122

merged 70 commits into from
Mar 3, 2025

Conversation

pbrubeck
Copy link
Collaborator

No description provided.

Robert C. Kirby and others added 30 commits February 19, 2025 16:39
WIP: Constant-of-Array may be better for code generation...
c7a6810
@pbrubeck
Fix Constant-of-numpy
b0ed47d
@pbrubeck
optimize flops
e632441
@pbrubeck
single matvec
f13e159
@pbrubeck
Ensure stage decoupling using ConstantOrZero
0ad4d44
@pbrubeck
numpy_to_ufl to cast identity, diagonal, triangular, or dense matrices
3fc8a99
Time derivatives push through list tensor, simplifying substitutions.…
7bd8944 
… Clean up the mess made elsewhere
@pbrubeck
Restore numpy matvec
ecd63fa
simplify stage value substitutions
3f421df
WIP: doing stage value + IMEX simplification
64659ab
few more fixes
1b61965
@pbrubeck
component_replace
a8d393f
lint
fac22ec
simplify replacements
5530dc6
simplify replacements
4162e15
simplify
7de6ae8
a further simplification
43f9083
fix lint
6160992
finish off component_replace transition
2b38b32
@pbrubeck
Update irksome/stage.py
c683d52
@pbrubeck
refactoring
700fbdc
@pbrubeck
Update tests/test_dirk.py
590234c
@pbrubeck
Apply suggestions from code review
b81cf2c
@pbrubeck
Rename files
480af6b
@pbrubeck
move StageDerivativeTimeStepper
fcff686
WIP: class structure?
849de48
add base class time stepper
7280625
WIP
2216e63
@pbrubeck
Fix Rana PC
c1f9360
@pbrubeck
StageCoupledTimeStepper WIP
e87aff6
@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from f1c9b84 to 2c2a125 Compare March 1, 2025 20:14
@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from 2c2a125 to 2fcc1a1 Compare March 1, 2025 20:29
@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from 1d9b579 to bf75275 Compare March 1, 2025 21:00
@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from bf75275 to ca3f05b Compare March 1, 2025 21:01
@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from 38a69f4 to 58cfb8b Compare March 2, 2025 17:06
@rckirby rckirby requested a review from ScottMacLachlan March 3, 2025 03:30
ScottMacLachlan
ScottMacLachlan approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@ScottMacLachlan ScottMacLachlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some documentation questions, this looks like it is in great shape to me. Many thanks!

@pbrubeck pbrubeck force-pushed the pbrubeck/unify-timesteppers branch from 32e357b to 69c96a7 Compare March 3, 2025 14:01
@rckirby rckirby merged commit 4211e8a into master Mar 3, 2025
2 checks passed
@rckirby rckirby deleted the pbrubeck/unify-timesteppers branch March 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby rckirby left review comments

@ScottMacLachlan ScottMacLachlan ScottMacLachlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbrubeck @rckirby @ScottMacLachlan