-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rckirby/explicit #90
Rckirby/explicit #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to see a test or two focused on the explicit time steppers. Is there a reason to not expand test_wave_energy.py
to run these schemes through their paces?
Yes, good point. I've done this now. |
This PR does two things:
stage_type="explicit"
instead ofstage_type="dirk"
. It automatically sets up SNES to never rebuild the jacobian or preconditioner, which is an optimization that works for RK. So users just have to provide mass matrix inversion parameters.