Fix boundary conditions #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2024 15:17
rckirby
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks for tackling this, it's long been a major annoyance. However, I tried out your change elsewhere (in test_stokes.py) and find that that is somehow broken. I expected stage value formulation to fail in that test since we haven't done similar updates to how that handles BC, but the classic stage-derivative form you attempted to fix is failing here. Please take a look.
pbrubeck
reviewed
Oct 18, 2024
pbrubeck
reviewed
Oct 18, 2024
pbrubeck
reviewed
Oct 18, 2024
pbrubeck
reviewed
Oct 18, 2024
pbrubeck
force-pushed
the
mingdonghe/fix/zero-bc
branch
from
f40e1a9 to
3f618be
Compare
pbrubeck
force-pushed
the
mingdonghe/fix/zero-bc
branch
from
3f618be to
52d56ef
Compare
rckirby
requested changes
Oct 18, 2024
| gdats_cur[i] = gblah_cur[i][0] | ||
| Vbigi = stage2spaces4bc(bc, V, Vbig, i) | ||
| gcur = replace(bcarg, {t: t+C[i]*dt}) | ||
| gcur = gcur - Vander_col[i] * bcarg |
There was a problem hiding this comment.
Modulo answers to @rckirby 's questions about the bounds-constrained case, this all makes sense to me. Seems much cleaner than what we were doing, and resolves a few things as well! Many thanks!
|
Right now, our only use cases are constant upper and/or lower bounds. I
think we should not make the perfect the enemy of the good. For now, if
you have a `Function` in the upper or lower bound and update it before the
solver is called, the new bounds will be in place. We don't have a
mechanism for `bounds` being an expression, but that's not an issue because
1) FD's bounds mechanism is the same and 2) you'd need a bounds-constrained
projection to pull it off..
…On Sun, Oct 20, 2024 at 7:57 AM ScottMacLachlan ***@***.***> wrote:
***@***.**** commented on this pull request.
Modulo answers to @rckirby <https://github.com/rckirby> 's questions
about the bounds-constrained case, this all makes sense to me. Seems much
cleaner than what we were doing, and resolves a few things as well! Many
thanks!
—
Reply to this email directly, view it on GitHub
<#98 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4XUL4TIQNOBDIGBIJITDDZ4OSCRAVCNFSM6AAAAABP5J26U6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBQGQ2DENRXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
rckirby
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow
DirichletBC(V, 0, ...), the special case requires no computation for stage boundary condition, everything should be zero