Set multigrid transfer managers using petsc options #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have to manually construct multigrid transfer managers by creating a
ManifoldTransferManagerand using the restrict/inject/prolong methods of that object to construct afiredrake.TransferManager. This meant that we couldn't just use the default constructor.The
ManifoldTransferManagerhas been refactored so we can now just use the default constructor. This means we can set the transfer manager for the blocks just using petsc options, similarly to setting python preconditioners. The explicit handling of transfer managers in the shallow water miniapp and in the circulant preconditioner can be removed.