Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybridisation using firedrake.SCPC #182

Merged
merged 27 commits into from
Apr 23, 2024
Merged

Hybridisation using firedrake.SCPC #182

merged 27 commits into from
Apr 23, 2024

Conversation

JHopeCollins
Copy link
Member

@JHopeCollins JHopeCollins commented Mar 26, 2024

Pulling out the reimplementation of hybridizationPC using SCPC from #152

This implementation requires a form_mass and form_function from the appctx, but will work with the vector implementation of complex-proxy as well as with >2 fields, whereas HybridizationPC can do any(?) form but is restricted to plain HDiv x L2 and only 2 fields.

Required:

  • Build form with form_mass and form_function
  • Allow the HDiv space to be at any index
  • Combine the complex-proxy implementation with the real implementation
  • Test for checking that the PC solves the real LSWE in one iteration
  • Test for checking that the PC solves the complex-proxy LSWE in one iteration

@JHopeCollins JHopeCollins added the enhancement New feature or request label Mar 26, 2024
@JHopeCollins JHopeCollins self-assigned this Mar 26, 2024
@JHopeCollins JHopeCollins mentioned this pull request Mar 26, 2024
4 tasks
@JHopeCollins
Copy link
Member Author

Additions (probably for later PRs as needed):

  • Deal with boundary conditions
  • Deal with extruded meshes with tensor product elements
  • Deal with nullspace
  • Add a view method

@JHopeCollins JHopeCollins merged commit f3d837d into master Apr 23, 2024
1 check passed
@JHopeCollins JHopeCollins deleted the hybrid_scpc branch April 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants