fix test pyop2 kernel compilation error with gcc14 #4099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since gcc14, some -Wincompatible-pointer-types are treated as error,
especially when you define func (int a[2][3]) {...}
and pass func with a pointer int p[6].
This pr might not be the best solution, however, one should fix the op2 kernel code in tests/pyop2/test_vector_map.py. e.g.
to
at the cost of less human readability.
related issue: #4096
I am a nixpkgs commiter on the roadmap to build/test/package firedrake/petsc with the power of nix build system which claim a reproducible firedrake environment.
Glad to see the Modernization of the installation of firedrake and its component.