Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version limitation on decorator #4100

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Mar 5, 2025

as far as i have tested on my firedrake develop enviroment built with nix, decorator 5.1.1 works well, and no test fails cause of newer version of decorator.

since old version of decorator conflict with ipykernel which is built with decorator 5.1.1.

can you test remove the version limitation of decorator on other platform.

Update:
these 4 pyop2 tests failed with decorator 5.1.1

FAILED tests/pyop2/test_api.py::TestDatAPI::test_dat_illegal_set - AttributeError: 'str' object has no attribute 'total_size'
FAILED tests/pyop2/test_api.py::TestDatAPI::test_dat_illegal_name[1] - Failed: DID NOT RAISE <class 'pyop2.exceptions.NameTypeError'>
FAILED tests/pyop2/test_api.py::TestDatAPI::test_dat_illegal_name[2] - Failed: DID NOT RAISE <class 'pyop2.exceptions.NameTypeError'>
FAILED tests/pyop2/test_api.py::TestDatAPI::test_dat_illegal_name[dset2] - Failed: DID NOT RAISE <class 'pyop2.exceptions.NameTypeError'>

@qbisi qbisi marked this pull request as draft March 5, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant