Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues from update to ufl (deleting brackets!) #464

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fix issues from update to ufl (deleting brackets!) #464

merged 6 commits into from
Nov 28, 2023

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Nov 15, 2023 •
edited
Loading

This fixes things that were broken by changes to FInAT and UFL. It:

  • deletes some brackets from methods called from space.ufl_element(), as these now seem to be properties.
  • changes the degree 1 Vtheta limiter as the DoF ordering changed
  • updates the KGO files for some tests given this

jshipton
jshipton approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done for tracking all those down @tommbendall !!

@jshipton jshipton merged commit a136ba3 into main Nov 28, 2023
4 checks passed
@jshipton jshipton deleted the ufl_update_fixes branch November 28, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshipton jshipton jshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommbendall @jshipton