Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor broken tests on main #468

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix minor broken tests on main #468

merged 1 commit into from
Dec 12, 2023

Conversation

tommbendall
Copy link
Contributor

This fixes the two tests broken on main (presumably from recent Firedrake updates):

  • by slightly slackening a tolerance in one test
  • updating the KGO for the linear SW wave test

jshipton
jshipton approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tommbendall

@jshipton jshipton merged commit 6e39d38 into main Dec 12, 2023
4 checks passed
@jshipton jshipton deleted the TBendall/more_tolerance_fixes branch December 12, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshipton jshipton jshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommbendall @jshipton