Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moist thermal example #478

Merged
merged 5 commits into from
Feb 29, 2024
+5 −3
Merged

Fix moist thermal example #478

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50fbb95
include missing spatial discretisation in moist thermal example
nhartney Feb 16, 2024
bc22c7d
changing qprecip and qr so that we get rain
Feb 19, 2024
0571778
Merge branch 'main' into fix_moist_thermal_example
nhartney Feb 26, 2024
d8c80a3
Merge branch 'main' into fix_moist_thermal_example
jshipton Feb 27, 2024
d18f0ec
Merge branch 'main' into fix_moist_thermal_example
jshipton Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
include missing spatial discretisation in moist thermal example
  • Loading branch information
@nhartney
nhartney committed Feb 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 50fbb956ad70e693c10ab93f094240c42924ddb8
4 changes: 3 additions & 1 deletion examples/shallow_water/moist_thermal_williamson5.py
View file
Original file line number Diff line number Diff line change
@@ -104,8 +104,10 @@ def gamma_v(x_in):
InstantRain(eqns, qprecip, vapour_name="cloud_water", rain_name="rain",
gamma_r=gamma_r)

transport_methods = [DGUpwind(eqns, field_name) for field_name in eqns.field_names]

# Timestepper
stepper = Timestepper(eqns, RK4(domain), io)
stepper = Timestepper(eqns, RK4(domain), io, spatial_methods=transport_methods)

# ----------------------------------------------------------------- #
# Initial conditions