-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1D shallow water equations #494
Conversation
aha, we used to make the velocity a vector with just one component... @tommbendall would you like to keep it like this (to test the usual code for the transport forms) or shall I change this test to use the new 1D forms? |
… 1dsw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that we'll finally be able to do this! As well as the picky individual comments, some broad thoughts:
- as we discussed offline it would probably be better for the normal form to return the 1D form if (a) the mesh is 1D and (b) the velocity is a scalar. Hopefully this will ensure that the tests pass
- could you rename the example to
shallow_water_1d.py
or something similar, for some reason I don't like it starting with a number!
… 1dsw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this now! I'll leave it un-merged so that you can do it if you think that it's ready
This PR adds an equation class for the 1D shallow water equations and the required 1D transport and diffusion terms.
To Do:
@tommbendall any comments / requests?