Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1D shallow water equations #494

Merged
merged 18 commits into from
Mar 28, 2024
Merged

1D shallow water equations #494

merged 18 commits into from
Mar 28, 2024

Conversation

jshipton
Copy link
Contributor

This PR adds an equation class for the 1D shallow water equations and the required 1D transport and diffusion terms.

To Do:

  • make example into a KGO test instead of an example
  • define linearisation
  • this won't work with SIQN without another bespoke linear solver - I'd rather not write that!

@tommbendall any comments / requests?

@jshipton
Copy link
Contributor Author

aha, we used to make the velocity a vector with just one component... @tommbendall would you like to keep it like this (to test the usual code for the transport forms) or shall I change this test to use the new 1D forms?

Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that we'll finally be able to do this! As well as the picky individual comments, some broad thoughts:

  • as we discussed offline it would probably be better for the normal form to return the 1D form if (a) the mesh is 1D and (b) the velocity is a scalar. Hopefully this will ensure that the tests pass
  • could you rename the example to shallow_water_1d.py or something similar, for some reason I don't like it starting with a number!

Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this now! I'll leave it un-merged so that you can do it if you think that it's ready

@jshipton jshipton merged commit f14eb5e into main Mar 28, 2024
4 checks passed
@jshipton jshipton deleted the 1dsw branch March 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants