Entropy #496
Merged
Entropy #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compressibleVorticity
… compressibleVorticity
|
It looks like this branch already includes all of the vorticity diagnostic changes, and these now conflict with changes on main. This means that this will either have to wait for the vorticity diagnostic (and you'll probably have to fix conflicts twice) or you could reimplement the vorticity diagnostic on a branch that comes cleanly off main? I think the entropy changes themselves look good but it'll be easier to see in a clean branch |
tommbendall
requested changes
May 24, 2024
gusto/diagnostics.py
Outdated
| @@ -682,6 +683,64 @@ def setup(self, domain, state_fields): | |||
| super().setup(domain, state_fields) | |||
|
|
|||
|
|
|||
| class Entropy(DiagnosticField): | |||
| """ base diagnostic field for entropy diagnostic """ | |||
There was a problem hiding this comment.
Suggested change
| """ base diagnostic field for entropy diagnostic """ | |
| """Base diagnostic field for entropy diagnostic""" |
| super().__init__(space=space, method=method, required_fields=tuple(required_fields)) | ||
|
|
||
|
|
||
| class PhysicalEntropy(Entropy): |
There was a problem hiding this comment.
Can you add a docstring here to help explain what this is? e.g.
u"""Physical entropy ρ*ln(θ) for Compressible Euler equations"""
tommbendall
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added entropy diagnostics for compressible euler equations