Remove guess of first value in explicit multistage scheme #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we revert to the previous KGO for the linear shallow water test? |
jshipton
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the start of each explicit multistage step, we initialise the expected result with our current field as a "guess".
This was added in #472 which came onto main in #469. It was an attempt to ensure that the explicit multistage schemes with the increment form developed in #413 could be used with conservative tracer transport. These equations do not have a unique solution if the density is zero, but provided a guess and using an iterative method helps to avoid issues).
However it appears that it may be causing problems in various tests! So this PR removes that line.