This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
update to webpack 4 #1157
Closed
update to webpack 4 #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice @unsign3d. Could you give this a go inside of https://github.com/firefox-devtools/debugger and see if you can install it locally? This is what i do: basically |
|
sure thing, should I publish it inside of the same PR? |
|
hmm, i just test it locally w/ npm pack
…On Wed, May 29, 2019 at 8:11 AM Luca Bruzzone ***@***.***> wrote:
sure thing, should I publish it inside of the same PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1157?email_source=notifications&email_token=AAB6EYWLLBHP247BLFTYIJ3PXZXHTA5CNFSM4HPO3TU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPD5EA#issuecomment-496909968>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB6EYWV5NAUAWRYJ44N7BLPXZXHTANCNFSM4HPO3TUQ>
.
--
--
Jason Laster
*Software Engineer*
*moz://a*
|
|
@jasonLaster we need to update also debugger in order to make it run properly, I will create a different PR there |
|
I'm temporary closing the pr since I don't have much time lately |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #964
Summary of Changes
Test Plan
Unit test and clicking around randomly in the UI