This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Opens launchpad on reload of previously closed external tab #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchevobbe
reviewed
Dec 16, 2017
|
|
||
| await updateConfig(); | ||
| return { tab, connTarget, tabConnection }; | ||
| if (debuggedTarget) { |
There was a problem hiding this comment.
maybe we want to show something if debuggedTarget is falsy ?
There was a problem hiding this comment.
Was thinking we could log an information to console that the tab has been closed as a result of the debugged source having been closed.
nchevobbe
approved these changes
Feb 15, 2018
|
Looks good, thanks @lukaszsobek |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #846
Summary of Changes
Test Plan
Screenshots/Videos