Ported Invoice PDF to Order PDF

[twosg]

Sorry for new pull request, I think this way it makes more sense to create a new branch instead of commiting to the development branch, doesn't it?

[twosg]

There is a bug with this. When I print the Order PDF, something goes wrong with the shipping tax which will be added to the detailed tax summary.

[sprankhub]

Thanks for your PR! I currently also do not really have the time to test and check, but I will try!

Could you check what total values are in the default/Firegento invoice for the same order? Are there different total values than in your screenshot?

[twosg]

The values only differ on the invoice, for both core Magento and Firegento invoice. On the invoice, totals are correctly although the shipping tax rate is not shown.

In the order PDF (my new Firegento renderer), the shipping tax is added to the 20% rate, as you can see in the screenshot.

I'll have a look on the actual values of the order and invoice if there are differences now:

And found the values are also displayed "wrong" at the admin area:

[sprankhub]

As long as the FireGento engine shows the same totals as the standard Magento engine, everything is okay. And this is the case, right?

[twosg]

Hi there,

yes it shows nearly the same. But it is not correctly, because it shows the Shipping and Handling tax seperate in the PDF, although the amount is already included within the "DE standard VAT" tax amount.

Compare the order PDF screenshot and the totals screenshot of the order. In admin area, it does not show the Shipping and Handling tax seperate, as it is included in the "DE standard VAT".

And this is not the case in the invoice totals, here the amount is correctly substracted? or calculated out of the standard VAT.