-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pager: cleanup generic resource and firehydrant client #23
Conversation
Cleaning up artifacts before we started using SQLite for consistent modeling.
@@ -62,70 +90,3 @@ func (v *VictorOps) LoadEscalationPolicies(ctx context.Context) error { | |||
console.Warnf("victorops.LoadEscalationPolicies is not currently supported.") | |||
return nil | |||
} | |||
|
|||
func (v *VictorOps) PopulateTeamMembers(ctx context.Context, team *Team) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically already broken, but I don't want to get too sidetracked right now. Will follow up with the implementation later!
func (f *FireHydrant) ListTeams(ctx context.Context) ([]*Team, error) { | ||
teams := []*Team{} | ||
stored, err := store.UseQueries(ctx).ListFhTeams(ctx) | ||
func (c *Client) ListTeams(ctx context.Context) ([]store.FhTeam, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much the changes are pager.Team -> store.FhTeam
and pager.User -> store.FhUser
. All other providers are already using store.Ext{Team,User}
, so the only one that's left is FireHydrant client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. This is good. I really like moving the FH stuff to its own package so it's even more clear that we're treating those differently.
Cleaning up artifacts before we started using SQLite for consistent modeling.
Also added
just build
for a quick test if things compile, automatically writing the output tobin/
which is in.gitignore
.