pager: cleanup generic resource and firehydrant client #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up artifacts before we started using SQLite for consistent modeling.
wilsonehusin
commented
Apr 29, 2024
| @@ -62,70 +90,3 @@ func (v *VictorOps) LoadEscalationPolicies(ctx context.Context) error { | |||
| console.Warnf("victorops.LoadEscalationPolicies is not currently supported.") | |||
| return nil | |||
| } | |||
|
|
|||
| func (v *VictorOps) PopulateTeamMembers(ctx context.Context, team *Team) error { | |||
There was a problem hiding this comment.
This is technically already broken, but I don't want to get too sidetracked right now. Will follow up with the implementation later!
| func (f *FireHydrant) ListTeams(ctx context.Context) ([]*Team, error) { | ||
| teams := []*Team{} | ||
| stored, err := store.UseQueries(ctx).ListFhTeams(ctx) | ||
| func (c *Client) ListTeams(ctx context.Context) ([]store.FhTeam, error) { |
There was a problem hiding this comment.
Pretty much the changes are pager.Team -> store.FhTeam and pager.User -> store.FhUser. All other providers are already using store.Ext{Team,User}, so the only one that's left is FireHydrant client.
AlexisJasso
approved these changes
Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up artifacts before we started using SQLite for consistent modeling.
Also added
just buildfor a quick test if things compile, automatically writing the output tobin/which is in.gitignore.