Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import PagerDuty schedule layers #6

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Import PagerDuty schedule layers #6

merged 6 commits into from
Apr 9, 2024

Conversation

wilsonehusin
Copy link
Member

@wilsonehusin wilsonehusin commented Apr 9, 2024 •
edited
Loading

This changeset enables on call schedules to be imported from PagerDuty. Each individual PagerDuty "Schedule Layer" is imported as a single FireHydrant schedule.

The program is aware of all schedules in the given PagerDuty account, but since schedules are owned by teams, only schedules associated with teams in the final Terraform file will be present in Terraform.

Done

  • Import layers of schedule
  • Render Terraform file for firehydrant_on_call_schedule

Not included in this PR

  • Custom scheduling strategy
  • Restrictions

@wilsonehusin wilsonehusin changed the title Import schedules Import PagerDuty schedule layers Apr 9, 2024
@wilsonehusin wilsonehusin requested a review from a team April 9, 2024 15:55
@wilsonehusin wilsonehusin marked this pull request as ready for review April 9, 2024 15:55
AlexisJasso
AlexisJasso approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@AlexisJasso AlexisJasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This looks fine. I'm assuming the test data is the right schema, but I suppose we'll find out pretty fast if it isn't. :P

@wilsonehusin
Copy link
Member Author

I suppose we'll find out pretty fast if it isn't. :P

The beauty of strongly typed languages!

@wilsonehusin wilsonehusin merged commit 0fbd112 into main Apr 9, 2024
3 checks passed
@wilsonehusin wilsonehusin deleted the wh/pde-1413-schedule branch April 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexisJasso AlexisJasso AlexisJasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilsonehusin @AlexisJasso