Exchange addresses which cannot be used as an output of private transaction #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
previously approved these changes
Nov 21, 2023
levonpetrosyan93
previously approved these changes
Nov 22, 2023
psolstice
force-pushed
the
exchange-address
branch
from
e5c3560
to
6e9b1cc
Compare
levonpetrosyan93
approved these changes
Nov 22, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
As a requirement from some exchanges we introduce a new type of transparent address for which it's not possible to use it as an output for both private and coinbase transactions
Code changes brief
A new opcode is introduced and new address prefix. The rest of the structure of private address and transactions is left intact. It is recommended to use
getnewexchangeaddressto create a pair for existing transparent address. Exchanges publish new address as a mean to deposit funds. Normal transparent address can used as a source for sending the funds further.